e2e: notebook infra/cleanup #9831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Tests 🚀 |
midleman
force-pushed
the
mi/e2e-nb-infra
branch
from
3760c86 to
15cb57a
Compare
midleman
force-pushed
the
mi/e2e-nb-infra
branch
from
62712e9 to
4257d2f
Compare
midleman
force-pushed
the
mi/e2e-nb-infra
branch
from
816ed76 to
3472650
Compare
midleman
force-pushed
the
mi/e2e-nb-infra
branch
from
f4b1498 to
e2a5f70
Compare
testlabauto
approved these changes
Oct 9, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The objective of this PR was to update some of the e2e Positron Notebook infra to make the tests more maintainable and reliable (fixed some flakes). I also removed a quite a few hardcoded waits that weren't necessary once the assertions were improved. I will be keeping an eye on them to quickly address any upcoming flakes.
QA Notes
@:positron-notebooks